Use SQL literals for column_definitions and pk_and_sequence_for
#1713
+16
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since these methods called via
to_sqlmethod underunprepared_statementFix #1678
Starting from Oracle enhanced adapter 5.2.0.beta1 most of the queries for the dictionary, such as all_sequences use bind variables by #1498 .
It should help shared memory usage however, which eventually means Oracle enhanced adapter 5.2+ only supports
prepared_statements: trueas Rails default configuration but it does not support
prepared_statements: false.Even if
prepared_statements: true,to_sqlusesunprepared_statementto generate SQL statement. If the connection already knows which table is associated with which model object in advance,to_sqlworks fine but whento_sqlexecuted first the connection needs to know these relation then callcolumn_definitions
andpk_and_sequence_for` methods at least.